Add linter #382
Merged
Add linter #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #337 as well as in #367 we use the quave config now.
I also did not yet added the lint check to the CI config because I think this should not be done before the respective packages are not moved to es6 and pass the linter.
Once a package is moved to es6 and passes the linter we can add it to the CI each step by step.
To lint a single package use in the test app
$ cd test-app $ meteor npm run lint:check -- ./packages/templating-compiler(The example only lints
templating-compiler)or use
To lint all packages. Same goes with the fix
lint:fixscript.