Remove duplicate results for same asset_ids in get_assets rpc method #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nagaprasadvr
requested changes
Dec 3, 2024
das_api/src/api/api_impl.rs
Outdated
| @@ -230,9 +241,13 @@ impl ApiContract for DasApi { | |||
|
|
|||
| let options = options.unwrap_or_default(); | |||
|
|
|||
| let assets = get_assets(&self.db_connection, id_bytes, batch_size as u64, &options).await?; | |||
| let unique_asset_ids = remove_duplicates_asset_ids(id_bytes); | |||
There was a problem hiding this comment.
filter dup ids at line no 237 and then convert to Vec<Vec<_>>
das_api/src/api/api_impl.rs
Outdated
| @@ -148,6 +149,16 @@ pub fn not_found(asset_id: &String) -> DbErr { | |||
| DbErr::RecordNotFound(format!("Asset Proof for {} Not Found", asset_id)) | |||
| } | |||
|
|
|||
| pub fn remove_duplicates_asset_ids(id_bytes: Vec<Vec<u8>>) -> Vec<Vec<u8>> { | |||
There was a problem hiding this comment.
can use generics here
|
suggested improvments implemented @Nagaprasadvr |
AhzamAkhtar
commented
Dec 4, 2024
| @@ -218,6 +224,7 @@ impl ApiContract for DasApi { | |||
| ) -> Result<Vec<Option<Asset>>, DasApiError> { | |||
| let GetAssets { ids, options } = payload; | |||
|
|
|||
| let ids = remove_duplicates_ids(ids); | |||
There was a problem hiding this comment.
also dont need to use generic now cause now we filtering only ids, which is Vec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In getAssets rpc method , a user can provide multiple same asset_id to search for, and the api will give that many duplicated results, instead we can return a single result.
Tasks