Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Token Type Filter in search_assets fuction #218

Conversation

AhzamAkhtar
Copy link

@AhzamAkhtar AhzamAkhtar commented Nov 15, 2024

Types of filters that are added in search_assets function are

  • Fungible
  • NonFungible
  • Compressed
  • Nft
  • All
  • Tests

Copy link
Collaborator

@Nagaprasadvr Nagaprasadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good , we can remove specification_asset_class in the query params

digital_asset_types/src/dao/mod.rs Outdated Show resolved Hide resolved
digital_asset_types/src/dao/mod.rs Show resolved Hide resolved
Copy link
Collaborator

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs integration tests @AhzamAkhtar

@AhzamAkhtar
Copy link
Author

Looks good but needs integration tests @AhzamAkhtar

Integration tests added @kespinola

@AhzamAkhtar AhzamAkhtar force-pushed the das-51-search-asset-token-type-filter branch from eeed8e6 to 4af136a Compare December 17, 2024 16:16
@AhzamAkhtar AhzamAkhtar marked this pull request as draft December 17, 2024 19:02
@AhzamAkhtar AhzamAkhtar force-pushed the das-51-search-asset-token-type-filter branch from d6b96d7 to bfe1fe0 Compare December 27, 2024 11:27
@AhzamAkhtar AhzamAkhtar force-pushed the das-51-search-asset-token-type-filter branch from bfe1fe0 to e1ad545 Compare December 27, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants