Add showCollectionMetadata option to view collection_metadata in rpc responce #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kespinola
requested changes
Nov 20, 2024
AhzamAkhtar
commented
Nov 26, 2024
kespinola
approved these changes
Nov 27, 2024
danenbm
reviewed
Dec 27, 2024
| { | ||
| "group_key": "collection", | ||
| "group_value": "J1S9H3QjnRtBbbuD4HjPV6RpRhwuk4zKbxsnCHuTgh9w", | ||
| "collection_metadata": {} |
There was a problem hiding this comment.
Shouldn't there be collection metadata here?
There was a problem hiding this comment.
It should but the metadata json uri isn't being fetched. Is there a helper in specs for fetching this? Can spoof it by writing info to the db so can be looked up by the API call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions that now supports showCollectionMetadata option -