Add env feature for clap #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
reviewed
Nov 14, 2024
| @@ -41,40 +41,40 @@ const SLOT_COLLECTION_OFFSET: u64 = 300; | |||
| )] | |||
| struct Args { | |||
| /// Path to the target RocksDB instance with slots | |||
| #[arg(short, long)] | |||
| #[arg(short, long, env)] | |||
There was a problem hiding this comment.
specify the Env name here?
StanChe
reviewed
Nov 14, 2024
.env.example
Outdated
| # Required by Postgre container | ||
| POSTGRE_DB_PATH="postgre/db/path" | ||
| ASSETS_ROCKS_DB_PATH="path/to/assets/db" | ||
| ASSETS_ROCKS_DB_SECONDARY_PATH="path/to/assets_secondary/db" |
There was a problem hiding this comment.
this one will be per service most likely. As it's secondary. Sometimes we could use temp dir for it or if we expect it to grow during the runtime.
StanChe
reviewed
Nov 14, 2024
.env.example
Outdated
| # Ingester instance config | ||
| INGESTER_LOG_LEVEL=info | ||
| SLOTS_ROCKS_DB_PATH="path/to/slots/db" | ||
| SLOTS_ROCKS_DB_SECONDARY_PATH="path/to/slots_secondary/db" |
StanChe
reviewed
Dec 6, 2024
| env_file: | ||
| - .env | ||
| network_mode: host | ||
| volumes: | ||
| - ${target_db_path}:${target_db_path}:rw | ||
| - ${INGESTER_PROFILING_FILE_PATH}:${INGESTER_PROFILING_FILE_PATH_CONTAINER}:rw | ||
| - ${TARGET_DB_PATH}:${TARGET_DB_PATH}:rw |
There was a problem hiding this comment.
value missing from .env.example.
Also some conflicts with the #310 are expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.