[MTG-777] Switching between storage instances #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RequescoS
reviewed
Oct 24, 2024
nft_ingester/src/rocks_db.rs
Outdated
| (duplicate_mode.current_rocks_db.load(Ordering::Relaxed) + 1) % 2; | ||
| let free_node = &duplicate_mode.rocks_db_instance[free_node_idx]; | ||
|
|
||
| while Arc::<rocks_db::Storage>::strong_count(&free_node) > 1 { |
There was a problem hiding this comment.
maybe also pass shutdown_rx here? we do not need to catch up DB when stop signal is sent to app
There was a problem hiding this comment.
catch_up will be fired only if clone_rx (main:229) is empty. Isn't it sufficient?
Or do you want to prevent the situation, when we continue catching up when received the shutdown_rx while waiting for Arcs to clear?
There was a problem hiding this comment.
yeap, the comment is about a situation you described
RequescoS
reviewed
Oct 29, 2024
nft_ingester/src/bin/api/main.rs
Outdated
| mutexed_tasks.clone(), | ||
| red_metrics.clone(), | ||
| MigrationState::Last, | ||
| ) | ||
| .unwrap(); | ||
|
|
||
| let rocks_storage = Arc::new(storage); | ||
| let secondary_storage_second_path = config | ||
| .rocks_db_secondary_path_container |
There was a problem hiding this comment.
We need to use another env. Now you are using config.rocks_db_secondary_path_container for both secondary_storage_second_path and secondary_storage_first_path but they must be different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new enum
RocksDbManageris provided.Its purpose is to leave the behavior of RocksDb primary mode as it was while providing an additional feature of switching secondary instances. It means, it means, in theory only one instance will be serving requests while the second will be catching up and vice versa in a perpetual loop.