openRpc doc #293
Open
openRpc doc #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
reviewed
Oct 23, 2024
openrpc.json
Outdated
| }, | ||
| "page": { | ||
| "name": "page", | ||
| "description": "Page based pagination (max 50)", |
There was a problem hiding this comment.
This one should be marked as deprecated and discouraged from usage. The recommended way to paginate is using the after or cursor fields. Examples should reflect this as well
openrpc.json
Outdated
| }, | ||
| "servers": [ | ||
| { | ||
| "url": "https://rpc.metaplex.com/this_is_fake" |
There was a problem hiding this comment.
Suggested change
| "url": "https://rpc.metaplex.com/this_is_fake" | |
| "url": "https://aura-mainnet.metaplex.com/" |
We also have https://aura-devnet.metaplex.com/
openrpc.json
Outdated
| "name": "asset" | ||
| } | ||
| ], | ||
| "params": [ |
There was a problem hiding this comment.
missing that shitload of filters
openrpc.json
Outdated
| }, | ||
| "showGrandTotal": { | ||
| "type": "boolean", | ||
| "description": "Show grand total" |
There was a problem hiding this comment.
Please figure out what this options do and add to the doc. You may ask teammates to figure this out or look at other refs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenRPC document draft WITHOUT examples
Just copy the whole json file and put it here https://playground.open-rpc.org to see doc