allow non-roundrobin manner of mesos scheduling #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val offerCPUs = getResource(resources, "cpus").toInt | ||
| var resources = remainingResources(offerId) | ||
|
|
||
| // sometimes you don't want to round-robin create |
There was a problem hiding this comment.
The method comment probably becomes ambiguous:
- Returns a map from OfferIDs to the tasks to launch on those offers. In order to maximize
- per-task memory and IO, tasks are round-robin assigned to offers.
|
I'm just wondering are we going to push this changes to apache/spark repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added an option to not assign tasks in round robin manner to mesos workers.
How was this patch tested?
Added a unit test