Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add otp/login spinner and fix roll number regex #24

Merged
merged 2 commits into from
Jul 13, 2024
Merged

add otp/login spinner and fix roll number regex #24

merged 2 commits into from
Jul 13, 2024

Conversation

Dami-18
Copy link

@Dami-18 Dami-18 commented Jul 13, 2024

No description provided.

proffapt
proffapt requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@proffapt proffapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the regex, it's fine if it gives false positives, but shouldn't give false negatives

proffapt
proffapt approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@proffapt proffapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this urgently, can add the regex separately.

@proffapt proffapt merged commit 35e616f into metakgp:main Jul 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proffapt proffapt proffapt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dami-18 @proffapt