Add character_type_implies_no_end DB constraint

Characters should never have an end date or area; this just enforces it
at the database level like we do with group genders.

admin/sql/CreateConstraints.sql

@@ -170,6 +170,19 @@ ADD CONSTRAINT group_type_implies_null_gender CHECK (
   OR type IS NULL
 );
 
+ALTER TABLE artist
+ADD CONSTRAINT character_type_implies_no_end CHECK (
+  (
+    type = 4 AND
+    end_date_day IS NULL AND
+    end_date_month IS NULL AND
+    end_date_year IS NULL AND
+    end_area IS NULL AND
+    ended = FALSE
+  )
+  OR type != 4
+);
+
 ALTER TABLE release_label
 ADD CHECK (catalog_number IS NOT NULL OR label IS NOT NULL);
 

admin/sql/updates/20241104-mbs-9885.sql

@@ -0,0 +1,29 @@
+\set ON_ERROR_STOP 1
+
+BEGIN;
+
+UPDATE artist
+SET end_date_day = NULL,
+    end_date_month = NULL,
+    end_date_year = NULL,
+    end_area = NULL,
+    ended = FALSE
+WHERE type = 4;
+
+ALTER TABLE artist
+DROP CONSTRAINT IF EXISTS character_type_implies_no_end;
+
+ALTER TABLE artist
+ADD CONSTRAINT character_type_implies_no_end CHECK (
+  (
+    type = 4 AND
+    end_date_day IS NULL AND
+    end_date_month IS NULL AND
+    end_date_year IS NULL AND
+    end_area IS NULL AND
+    ended = FALSE
+  )
+  OR type != 4
+);
+
+COMMIT;

admin/sql/updates/schema-change/30.master_and_standalone.sql

@@ -0,0 +1,35 @@
+-- Generated by CompileSchemaScripts.pl from:
+-- 20241104-mbs-9885.sql
+\set ON_ERROR_STOP 1
+BEGIN;
+SET search_path = musicbrainz, public;
+SET LOCAL statement_timeout = 0;
+--------------------------------------------------------------------------------
+SELECT '20241104-mbs-9885.sql';
+
+
+UPDATE artist
+SET end_date_day = NULL,
+    end_date_month = NULL,
+    end_date_year = NULL,
+    end_area = NULL,
+    ended = FALSE
+WHERE type = 4;
+
+ALTER TABLE artist
+DROP CONSTRAINT IF EXISTS character_type_implies_no_end;
+
+ALTER TABLE artist
+ADD CONSTRAINT character_type_implies_no_end CHECK (
+  (
+    type = 4 AND
+    end_date_day IS NULL AND
+    end_date_month IS NULL AND
+    end_date_year IS NULL AND
+    end_area IS NULL AND
+    ended = FALSE
+  )
+  OR type != 4
+);
+
+COMMIT;

upgrade.json

@@ -230,5 +230,10 @@
       "20240223-mbs-13421-fks.sql",
       "20240319-mbs-13514.sql"
     ]
+  },
+  "30": {
+    "master_and_standalone": [
+      "20241104-mbs-9885.sql"
+    ]
   }
 }