Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back inserted_at field to export #3054

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maxr1998
Copy link
Contributor

@Maxr1998 Maxr1998 commented Dec 1, 2024

This was part of the previous exports and should probably be kept. Untested, but should hopefully work.

I also noticed that the recording_msid is now part of the track_metadata, while previously it was part of both the listen object and the additional_info.

@mayhem
Copy link
Member

mayhem commented Dec 2, 2024

@Maxr1998
Copy link
Contributor Author

Maxr1998 commented Dec 2, 2024

I'd love to, but it appears that the asserts currently compare to the uploaded JSON, which shouldn't contain insertion timestamps. I don't think I understand the test architecture well enough to handle it. Do you maybe have some pointers on what needs to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants