Split SRC_URI list into inc file #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to edition 2021 requires fixing some minor issues and doing a cargo update.
Usually generated bitbake recipes need to be slightly altered before they can be used to build the rust project. This might be tweaking some URLs, adding non-rust dependencies, and a variety of other things. Typically these changes will be made to the generated recipe and then checked in to a yocto layer. As the rust project changes it will usually pull in additional crates over time. Whenever this happens the recipe will be re-generated and these changes will need to be merged back in. This is a lot of work to do when the only change is the addition of one or two crates to the SRC_URI list. Let's make this process a little easier by splitting the SRC_URI list out into a separate inc file and including this in the main recipe. Now the recipe can be kept up-to-date by just updating the separate inc file--no more recipe merging.
|
+@srwalter @weltling @jmesmon @ColinFinck looks like you've all contributed to meta-rust, any thoughts on this change? |
|
It might be beneficial to begin utilizing bb recipe foreach dependency. What are your thoughts on it and on incorporating 'include {PN}' and '{PN}-{PV}' similar to the current cargo-bitbake output? Aligning with the Rust shared runtime library when feasible could be advantageous. Somehow, this approach could assist with #73. |
|
How about adding a command line option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually generated bitbake recipes need to be slightly altered before
they can be used to build the rust project. This might be tweaking some
URLs, adding non-rust dependencies, and a variety of other things.
Typically these changes will be made to the generated recipe and then
checked in to a yocto layer.
As the rust project changes it will usually pull in additional crates
over time. Whenever this happens the recipe will be re-generated and
these changes will need to be merged back in. This is a lot of work to
do when the only change is the addition of one or two crates to the
SRC_URI list.
Let's make this process a little easier by splitting the SRC_URI list
out into a separate inc file and including this in the main recipe. Now
the recipe can be kept up-to-date by just updating the separate inc
file--no more recipe merging.
While we're at it let's also update to edition 2021.