-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature persist compass calibration #5562
Open
danwelch3
wants to merge
16
commits into
meshtastic:master
Choose a base branch
from
danwelch3:feature-persist-compass-calibration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature persist compass calibration #5562
danwelch3
wants to merge
16
commits into
meshtastic:master
from
danwelch3:feature-persist-compass-calibration
+416
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only active for BMX160 accelerometers on RAK_4631 - replace automatic calibration on power on with button triggered calibration - set 5 presses to trigger 30s calibration - set 6 presses to trigger 60s calibration (useful if unit is not handheld, ie vehicle mounted) - show calibration time remaining on calibration alert screen
- exclude changes from non RAK 4631 builds - remove calls to screen when not present
- exclude all compass heading updates on variant without screen
- move compass calibration highest/lowest XYZ to struct for easier load/save - implement littleFS load/save of compass calibration values
- change updateState function to saveState function for clarity - increase max save size
- initiate calibration with first read values to account for min values > 0
- fix orientation vectors based on acceleration from calibration - re-zero calibration data after running calibration to start fresh on next calibration
Additional changes have been made to work towards making these compass features available to non RAK & BMX160 devices. These include moving calibration routines into the MotionModule as well as determining sensor orientation as part of the calibration process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persists BMX160 sensor compass calibration data so that the user can avoid re-calibrating every time the unit is powered up.
Builds on PR #5553