Move config.yaml into exampleSite directory #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I now saw #1 and I'm not sure about your closing remark #1 (comment). As far as I know the theme contains a theme.toml and not a hugo config file (like hugo.toml or config.yaml) as this is project related - not theme related. Therefore most themes have a project settings file in the exampleSite directory. Feel free to close this PR if I got something wrong here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My build failed while trying to use the theme because the config.yaml was not in the exampleSite but instead in the root directory.
The Readme is already correct as it says:
So no other change needed, as far as I can see.