Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid attribute for MSVC #3117 #3118

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

OgreTransporter
Copy link
Contributor

Replace __attribute__((packed)) with #pragma pack for MSVC to fix compiler errors. Solves issue #3117.

@zuckschwerdt
Copy link
Collaborator

I think just pragma should do. I.e.

#pragma pack(push, 1)
struct deltadore_x3d_message_payload {
...
#pragma pack(pop)

@zuckschwerdt
Copy link
Collaborator

I just noticed that no packing is actually needed. Change the PR to just remove the attribute please :)

@OgreTransporter
Copy link
Contributor Author

I think just pragma should do. I.e.

Unfortunately, I don't know if other compilers can handle #pragma pack, so I added the distinction.

@zuckschwerdt
Copy link
Collaborator

Closes #3117

@zuckschwerdt zuckschwerdt merged commit 14e6d21 into merbanan:master Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants