Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shuffling bug, poetry updates, and upper bound torch version #153

Closed
wants to merge 0 commits into from
Closed

Fix shuffling bug, poetry updates, and upper bound torch version #153

wants to merge 0 commits into from

Conversation

pzdkn
Copy link
Contributor

@pzdkn pzdkn commented Oct 24, 2023

Description

Fix the issue
#143

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@pzdkn pzdkn changed the title fix bug and bump poetry pre-commit version Fix shuffling bug, poetry updates, and upper bound torch version Oct 25, 2023
AlirezaSohofi
AlirezaSohofi reviewed Oct 25, 2023
View reviewed changes
squirrel/iterstream/base.py Outdated
Comment on lines 236 to 237
if size is None:
size = 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not def shuffle(self, size: Optional[int] = 1000, **kw) -> Composable: ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bc of my stupidity 😅

@pzdkn pzdkn closed this Nov 10, 2023
@pzdkn pzdkn force-pushed the peng-fix-shuffle-default-size-bug branch from be4663a to 5fa094d Compare November 10, 2023 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@pzdkn pzdkn deleted the peng-fix-shuffle-default-size-bug branch November 10, 2023 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlirezaSohofi AlirezaSohofi AlirezaSohofi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzdkn @AlirezaSohofi