Fix/scaling issues for tokens with less than 18 decimals #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbow61
reviewed
Dec 4, 2024
nvtaveras
approved these changes
Dec 4, 2024
philbow61
deleted the
fix/scaling-issues-for-tokens-with-less-than-18-decimals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the scaling issues we have in the GoodDollarExpansionController.sol by scaling up
reserveInterestinmintUBIFromReserveBalanceandmintUBIFromInterestand removing the scaling inmintFromInterestOther changes
_createExchangeto scale tokens with less than 18 decimals instead of leaving that to the callers initiativeTested
Fixed old unit tests, introduced new integration tests
Related issues