feat: Improve how the initial allocation is forwarded.

[bowd]

Description

When we moved to a dynamic initial allocation calculation, we did something that has the potential for confusion: we're passing in two arrays to the GovernanceFactory contract:

• additionalAllocationRecipients
• allocationAmounts
  With the implicit idea that allocationAmounts.length == additionalAllocationRecipients.length + 2 and that the first two allocationAmounts relate to the airgrab and the Mento Treasury.

Even tho this is a one time thing I find that this adds the potential for confusion and will also make reviews more complicated.
I propose simplifying this by introducing an initial allocation struct:

  struct MentoTokenAllocationParams {
    uint256 airgrabAllocation;
    uint256 mentoTreasuryAllocation;
    address[] additionalAllocationRecipients;
    uint256[] additionalAllocationAmounts;
  }

This explicitly defines the two "implicit" allocations and then has an array of 1:1 additional recipients and amounts.
It's also nicer to read when reviewing the CGP (in the cgp-viewer app I wrote):

Other changes

N/A

Tested

• Tests covered

Backwards compatibility

N/A

Documentation

N/A

[openzeppelin-code]

feat: Improve how the initial allocation is forwarded.

Generated at commit: fdaafc7c4c1aa597711f5168c9de995fd7a79037

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 1 0 16 40 59
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[chapati23]

lgtm 👍

[baroooo]

✅