Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make emissions Upgradable #365

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

bowd
Copy link
Contributor

@bowd bowd commented Feb 12, 2024

Description

Based on recent token conversations, we've decided to forgo the immutable emissions schedule and want to make the emissions contract upgradable.

Other changes

N/A

Tested

  • Tests updated to reflect

Backwards compatibility

N/A

Documentation

N/A

@bowd bowd requested review from baroooo and chapati23 February 12, 2024 10:45
Copy link

openzeppelin-code bot commented Feb 12, 2024

feat: Make emissions Upgradable

Generated at commit: 86b7b6d8af784b1b2966ed96954c6b5fbe84b8b3

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
16
40
59
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@bowd bowd changed the title Make emissions Upgradable feat: Make emissions Upgradable Feb 12, 2024
Copy link
Contributor

@baroooo baroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + I added emission to upgradability integration test

@bowd
Copy link
Contributor Author

bowd commented Feb 12, 2024

LGTM + I added emission to upgradability integration test

Thanks! Missed that! <3

Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, couldn't find anything missing

just created a small ticket as a reminder to upgrade the governance-tests repo with en upgradeabilit test for Emissions after this is merged mento-protocol/governance-tests#17

@bowd bowd merged commit 5833bc7 into feat/tokenWork Feb 13, 2024
1 of 15 checks passed
@chapati23 chapati23 deleted the feat/make-emissions-upgradable branch February 14, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants