Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rollback description - see issue rollback-object #8498 #8837

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

MarkvanMents
Copy link
Collaborator

@akkrishnakumar
Copy link
Contributor

akkrishnakumar commented Jan 3, 2025

I approve this change.

Reason being -

The one mentioned in the docs (“made to the object in the part of the flow preceding the activity”), it feels like it refers to the flow in the current executing MF. This could be misleading because any changes made in the parent MF will also be reverted/rollbacked if not committed.

But the one suggested by the customer (rolls back all changes, not persisted to the database), it clearly says that All Changes , be it in the current flow or parent flow will be reverted/rollbacked if not committed. This seems to be more correct, IMO

@MarkvanMents
Copy link
Collaborator Author

Thanks for the review @akkrishnakumar.
Merging this change now.

@MarkvanMents MarkvanMents merged commit 129bcbd into development Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants