Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename files after a source format change #586

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Rename files after a source format change #586

wants to merge 27 commits into from

Conversation

tcely
Copy link
Contributor

@tcely tcely commented Dec 17, 2024

Fixes #185

@tcely
Copy link
Contributor Author

tcely commented Dec 17, 2024

Help is wanted for creating tests for this.

Please click on my branch and open a pull request to merge any charges you would like to make into my branch. Thanks!

@tcely tcely mentioned this pull request Dec 17, 2024
Open
@tcely tcely marked this pull request as ready for review December 17, 2024 23:27
tcely added 22 commits December 17, 2024 18:36
@tcely
Import rename_all_media_for_source too
ba0449b
@tcely
Ensure the directory exists
4193e79
@tcely
Fixes from testing
fdbfd33 
I don't know how I missed `.suffix` on the later `stem` loop. Oops.
@tcely
Prioritize rename before checking for new media
278a92b
@tcely
Rewrite the .nfo file when the thumb path changed
8f0825b
@tcely
Escape fnmatch special characters in old_stem
40aed6f
@tcely
Fixup use of _glob_translation
4b17c08
@tcely
More fixes after glob worked
9be9b0c 
stem should be:
1) a stem
2) a string

Replace temporary .nfo into the new directory.
@tcely
Avoid glob matching the video itself
2ffeb5e
@tcely
Use the database values in the current instance
3a2157e
@tcely
Add directory_and_stem and mkdir_p
a33620f
@tcely
Use mkdir_p in youtube.py
80a7718
@tcely
Use mkdir_p in models.py
02f1d08
@tcely
Don't return suffixes
0e18d6d 
This isn't useful.
The caller can create a `Path` to get this instead.
@tcely
Use directory_and_stem in models.py
35912f0
@tcely
Add glob_quote
9168e82
@tcely
Use glob_quote in models.py
e3bcd78
@tcely
Try to rename lost files by key
521b903
@tcely
Try not to leave empty directories around
344759e
@tcely
Use TypeError in glob_quote
72e4095
@tcely
Depend on the function to write a temporary file
4f56ebd
@tcely
Added logging to rename_files
2ee6351 
Also, the fuzzy matching, by key in the filename, begins at the source directory.
@meeb
Copy link
Owner

meeb commented Dec 22, 2024

Thanks! This will need a bit more of a thorough review, I'll try and look at this over the break but I'm a away a far bit until Jan.

@tcely
Copy link
Contributor Author

tcely commented Dec 22, 2024 •
edited
Loading

Of course. I want more eyes on these changes.

I'm currently running this code and I'm happy with how it is behaving, but I did a fair bit of manual intervention as TubeSync had lost track of files as format changed over the time I've been using it.

During this process, having the media_file.path displayed on the media item page was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to rename the files of downloaded vidoes?
2 participants
@tcely @meeb