Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding options to pod execution #21

Merged

Conversation

mshitrit
Copy link
Member

adding options to pod execution:

  • allowing execution of commands without expected output
  • allowing using a user defined pod executing

- allowing execution of commands without expected output
- allowing using a user defined pod executing

Signed-off-by: Michael Shitrit <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mshitrit mshitrit changed the title [WIP] adding options to pod execution adding options to pod execution Jan 29, 2024
@mshitrit mshitrit marked this pull request as ready for review January 29, 2024 13:31
@openshift-ci openshift-ci bot requested review from clobrano and slintes January 29, 2024 13:31
Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function description should be updated to clarify that only the 1st RunOptions is actually used (as the variadic argument is used to allow no RunOptions). Otherwise, you might think of defining two APIs, one with 1 RunOptions (user defined) and one without RunOptions, which internally calls the first passing the default RunOptions.

test/command/command.go Outdated Show resolved Hide resolved
… with standard patterns

Signed-off-by: Michael Shitrit <[email protected]>
@mshitrit mshitrit force-pushed the add-options-for-pod-executor branch from 02c0885 to 4da13fe Compare February 1, 2024 09:10
@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2024
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano
Copy link
Contributor

clobrano commented Feb 5, 2024

/lgtm
Giving a chance to get more reviews, feel free to unhold
/hold

@mshitrit
Copy link
Member Author

mshitrit commented Feb 5, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 35bee23 into medik8s:main Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants