-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding options to pod execution #21
adding options to pod execution #21
Conversation
- allowing execution of commands without expected output - allowing using a user defined pod executing Signed-off-by: Michael Shitrit <[email protected]>
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the function description should be updated to clarify that only the 1st RunOptions is actually used (as the variadic argument is used to allow no RunOptions). Otherwise, you might think of defining two APIs, one with 1 RunOptions (user defined) and one without RunOptions, which internally calls the first passing the default RunOptions.
… with standard patterns Signed-off-by: Michael Shitrit <[email protected]>
02c0885
to
4da13fe
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, mshitrit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/unhold |
adding options to pod execution: