Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always record history on component insert #603

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

chrisvxd
Copy link
Member

@chrisvxd chrisvxd commented Sep 7, 2024

This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 6:37pm
puck-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 6:37pm

Copy link
Contributor

@mkilpatrick mkilpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed

This will result in duplicate history entries if the item has a resolveData method. This is difficult to prevent without a deferredDispatch method, similar to that being explored in #598.
@chrisvxd chrisvxd force-pushed the always-record-insert-history branch from 09c468d to 78b6c9c Compare September 9, 2024 18:35
@chrisvxd chrisvxd merged commit 88c5ab6 into main Sep 9, 2024
4 checks passed
@chrisvxd chrisvxd deleted the always-record-insert-history branch September 9, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants