fix(android): use process death time instead of current time for AppExit timestamp #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time at which the AppExit event is collected is not useful. We're more interested in the time at which the app actually exited. This also fixes a related issue in session replay where session duration is calculated based on the time of the last event. `AppExit` is typically the last event for a session and using current time as it's timestamp makes the session duration incorrect. fixes: #953
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
detj
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The time at which the AppExit event is collected is not useful. We're more interested in the time at which the app actually exited. This PR uses the app exit time as the
AppExitevent timestamp instead of the time at which the event was collected.This also fixes #953, a related issue in session replay, where session duration for sessions with app exit event was incorrect.