Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(android): implement batch insertions of events and spans in db #1659

Merged
merged 1 commit into from
Dec 24, 2024
Merged

refactor(android): implement batch insertions of events and spans in db #1659

merged 1 commit into from
Dec 24, 2024

Conversation

abhaysood
Copy link
Contributor

Description

  • Buffer events and spans in SignalStore
  • Persist buffer at time of crash, when app goes to background and periodically every 3 seconds.

Closes: #1642

@abhaysood abhaysood added refactor refactoring tasks android android related labels Dec 24, 2024
@abhaysood abhaysood requested a review from detj December 24, 2024 09:29
@abhaysood abhaysood self-assigned this Dec 24, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
measure-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 9:29am

@abhaysood abhaysood merged commit 4739514 into main Dec 24, 2024
9 checks passed
@abhaysood abhaysood deleted the batch-insert branch December 24, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detj detj detj approved these changes

Assignees

@abhaysood abhaysood

Labels
android android related refactor refactoring tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement batch insert for events and spans to reduce fsync operations
2 participants
@abhaysood @detj