fix(backend): make span name query param #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anupcowkur
force-pushed
the
fix-span-name
branch
from
140eb8d to
1c6c734
Compare
fixes #1575 spans with names like 'GET developer.android.com/...' cannot be passed as part of url path in Gin. It confuses the routing system and results in 404s. This commit fixes the issue by passing in span names as query params instead of as part of the path.
anupcowkur
force-pushed
the
fix-span-name
branch
from
1c6c734 to
aefe3da
Compare
abhaysood
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spans with names like 'GET developer.android.com/...' cannot be passed as part of url path in Gin. It confuses the routing system and results in 404s.
This commit fixes the issue by passing in span names as query params instead of as part of the path.
Related issue
Fixes #1575