fix(android): blank screenshots for Android 15 #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where screenshots on Android 15 were blank. This happened due to incorrect usage of PixelCopy, where instead of using the completion listener the code was assuming `PixelCopy.request` to work synchronously. This likely broke only in Android 15 because the following PR: https://android-review.googlesource.com/c/platform/frameworks/base/+/3015073
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anupcowkur
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where screenshots on Android 15 were blank. This happened due to incorrect usage of PixelCopy, where instead of using the completion listener the code was assuming
PixelCopy.requestto work synchronously.This likely broke only in Android 15 after the following PR was merged:
https://android-review.googlesource.com/c/platform/frameworks/base/+/3015073
How is this tested?
Manually using an Android 15 emulator.
Related issue
Fixes #1222