chore(backend): fix session data #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update session data files to replace all occurences of `network_provider_name` with `network_provider` - update session data files to replace all occurrences of `"network_provider":null` to `"network_provider":"unknown"` fixes #1097
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anupcowkur
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pagination was not working correctly because of inconsistencies in session data. Some events had property names with
network_provider_nameinstead of the expectednetwork_provider. Moreover, some values fornetwork_providerhad valuesunknownwhile some had the valuenull. This PR fixes those inconsistencies.Pagination works as expected after a fresh ingestion via sessionator.
Tasks
network_provider_namewithnetwork_provider"network_provider":nullto"network_provider":"unknown"Notes to maintainers
After pulling the
mainbranch, please run sessionator's ingest command with the--cleanflag to get rid of the broken pagnination effect for your local environment.Related issues
fixes #1097