Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): proceed with event ingestion on symbolication failure #1134

Merged
merged 1 commit into from
Aug 26, 2024
+4 −8
Merged

fix(backend): proceed with event ingestion on symbolication failure #1134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions backend/api/measure/event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1867,25 +1867,21 @@ func PutEvents(c *gin.Context) {
_, symbolicationSpan := symbolicationTracer.Start(ctx, "symbolicate-events")

for i := range batches {
// If symoblication fails for whole batch, continue
if err := symbolicator.Symbolicate(ctx, batches[i]); err != nil {
msg := `failed to symbolicate batch`
fmt.Println(msg, err)
c.JSON(http.StatusInternalServerError, gin.H{
"error": msg,
"details": err.Error(),
})
symbolicationSpan.End()
return
continue
}

// handle symbolication errors
// If symbolication succeeds but has errors while decoding individual frames, log them and proceed
if len(batches[i].Errs) > 0 {
for _, err := range batches[i].Errs {
fmt.Println("symbolication err: ", err.Error())
}
}

// rewrite symbolicated events
// rewrite symbolicated events to event request
for j := range batches[i].Events {
eventId := batches[i].Events[j].ID
idx, exists := eventReq.symbolicate[eventId]
Expand Down