chore(backend): proxy s3 attachments by default #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
- by default all attachments are proxied via s3 presigned urls - previous no proxy behavior can also be configured - reorganize routes so that not found route can function normally - add new api endpoint to reverse proxy presigned s3 attachments
- update attachment origin settins in `self-host/config.sh`
anupcowkur
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to reduce onboarding friction for self host users, we'll default to using minio for uploading and fetching attachment blobs. This way, users will not require to acquire a DNS domain/subdomain for handling of attachments. Thereby, making the self hosting experience a tad bit smoother.
Tasks
/attachments?payload=[partial-presigned-url]API for reverse proxying to S3 backend.self-host/config.shscript to reflect updated config state404 Not Foundcases does not get eaten up by other routes.Flow
Here's the flow showing both proxy & no proxy mechanism.
No Proxy
sequenceDiagram Frontend->>+Backend: want session replay Backend-->>-Frontend: here you go Frontend->>+Minio: fetch me this attachment Minio-->>-Frontend: here you goProxy
sequenceDiagram Frontend->>+Backend: want session replay Backend-->>-Frontend: here you go Frontend->>+Backend: fetch me this attachment Backend->>+Minio: fetch me this attachment Minio-->>-Backend: here you go Backend-->>-Frontend: here you go