Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): configure http urls to collect events for allowed urls #1020

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

abhaysood
Copy link
Contributor

@abhaysood abhaysood commented Aug 9, 2024

Adds a new configuration httpUrlAllowlist.
Allows enabling collection of http events only for certain URLs. This is useful to setup if you want to collect data only for certain endpoints or third party domains. If this list is empty, httpUrlBlocklist is considered. By default, this list is empty.

It also fixes an issue where trackHttpHeaders and trackHttpBody configs were being ignored.

closes #1019, #1021

@abhaysood abhaysood added the feature new features label Aug 9, 2024
@abhaysood abhaysood requested a review from detj August 9, 2024 13:19
@abhaysood abhaysood self-assigned this Aug 9, 2024
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
measure-web-app ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 1:37pm

Adds a new configuration `httpUrlAllowlist`.
Allows enabling collection of `http` events only for certain URLs.
This is useful to setup if you want to collect data only for certain
endpoints or third party domains. If this list is empty,
`httpUrlBlocklist` is considered. By default, this list is empty.
@abhaysood abhaysood added the bug something isn't working label Aug 9, 2024
@abhaysood abhaysood merged commit 5f55012 into main Aug 9, 2024
4 of 5 checks passed
@abhaysood abhaysood deleted the url-allowlist branch August 9, 2024 13:39
@abhaysood abhaysood changed the title feat(android): configure http urls to collect events for feat(android): configure http urls to collect events for allowed urls Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working feature new features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(android): implement an allow list of URLs for which to enable http event tracking for
2 participants