Skip to content

Commit

Permalink
fix(backend): ignore cold launch greater than 30s for metrics calcula…
Browse files Browse the repository at this point in the history
…tion

fixes #933
  • Loading branch information
anupcowkur committed Jul 22, 2024
1 parent 1fd30d6 commit 333bb24
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions measure-backend/measure-go/measure/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,7 @@ func (a App) GetLaunchMetrics(ctx context.Context, af *filter.AppFilter, version
Select("round(quantile(0.95)(cold_launch.duration), 2) as cold_launch").
Where("type = 'cold_launch'").
Where("cold_launch.duration > 0").
Where("cold_launch.duration <= 30000"). //ignore cold launch durations greater than 30 seconds. See https://github.com/measure-sh/measure/issues/933
Where("attribute.app_version in ? and attribute.app_build in ?", af.Versions, af.VersionCodes)).
With("warm_selected",
sqlf.From("timings").
Expand Down

0 comments on commit 333bb24

Please sign in to comment.