Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to scala 2.11.2 (supports 2.10.4), dropped support for 2.9.x #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cosminbasca
Copy link

several changes such that tests pass, and the new API's are supported
bumped version to 0.0.7

works on my box (max os x 10.9.4)

…X has been dropped.

tests pass on both scala versions
fixed resource loading for large graphs (correct utf-8 encoding specified explicitly - otherwise the system default one is chosen)
bumped version to 0.0.7
updated sbt plugins
included sbt assembly plugin support
switched to sbt 0.13.0

all tests pass on my mac box (10.9.4)
@buildhive
Copy link

Matt Russell » ascii-graphs #60 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@cosminbasca
Copy link
Author

Hi Matt,

the Buildhive error I got back immediately after sending the pull request:

[ERROR] Terminal initialization failed; falling back to unsupported
java.lang.IncompatibleClassChangeError: Found class jline.Terminal, but interface was expected

is due to wrong version of sbt-launcher used (most likely 0.12.x instead of the required 0.13.x). The tests will pass with an updated version of sbt-launcher.

Cheers,
Cosmin

@alexarchambault
Copy link

👍

@mdr Any chance of something along those lines to be merged? I updated things on my side too (https://github.com/alexarchambault/ascii-graphs/tree/topic/scala-2.11).

@tribbloid
Copy link

Hi @alexarchambault, looks all good to me, are you interested in release on centrol maven repository?
BTW the latest version is Scala 2.11.7 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants