Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure #69

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Fix build failure #69

merged 3 commits into from
Jul 12, 2024

Conversation

eytanadler
Copy link
Collaborator

Purpose

The build failed because of a numpy typing import from within PIL within matplotlib. Bumping the numpy version to the point of it having NDArray in numpy.typing should fix the problem.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Maintenance

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner July 11, 2024 13:54
@eytanadler eytanadler requested review from lamkina and kanekosh July 11, 2024 13:54
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (7ab3c6a) to head (c69bf49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   82.08%   82.08%           
=======================================
  Files         103      103           
  Lines       10717    10717           
=======================================
  Hits         8797     8797           
  Misses       1920     1920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eytanadler
Copy link
Collaborator Author

FYI, the hanging tests are because the test names changed when I changed numpy from 1.20 to 1.21, but the GitHub site still has the 1.20 test name required. Once this PR is merged, I'll update the required tests to fix it.

@eytanadler eytanadler merged commit 1032ad4 into mdolab:main Jul 12, 2024
13 checks passed
@eytanadler eytanadler deleted the fix_build branch July 12, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants