Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In savefigs, we allow the user to pass either a list of formats (e.g
["png", "pdf"]
) or a single format string (e.g"png"
). In theory, when the user passes in a single string, we convert it to a single entry list so that we always have a list of formats to loop through:However, a string is iterable, so what actually happens when the user passes in a single format string is we don't put it in a list and instead loop over the individual character in the string. So I just changed logic to check if the input is a string.
Expected time until merged
NOW
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable