Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel config #14

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Intel config #14

wants to merge 6 commits into from

Conversation

hajdik
Copy link
Collaborator

@hajdik hajdik commented Feb 19, 2024

Purpose

The intel config didn't work on Pleiades so I added the switch in the IDWarp intel config which did successfully build on the cluster and relevant pyGeo tests passed. I didn't refactor the rest of the config as it does work but if there are best practices to follow I can do so.

Also edited some Python files to address Black rules that are new since the last GeoGrad PR.

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Config runs on intel images

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@hajdik hajdik requested a review from a team as a code owner February 19, 2024 21:56
@hajdik hajdik requested review from eirikurj, bernardopacini and sseraj and removed request for bernardopacini February 19, 2024 21:56
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following other best practices would be a much larger effort and would probably involve restructuring the repo a bit. I opened #15 to track some updates that should be made eventually.

This looks fine other than the Python formatting and my one comment below.

config/defaults/config.LINUX_INTEL.mk Outdated Show resolved Hide resolved
@eirikurj
Copy link
Contributor

bump @hajdik

1 similar comment
@eirikurj
Copy link
Contributor

bump @hajdik

@hajdik
Copy link
Collaborator Author

hajdik commented Oct 9, 2024

I addressed @sseraj's comment and fixed the black check. I'll address the broader restructuring in #15 soon.

@marcomangano marcomangano requested review from eirikurj and removed request for eirikurj October 14, 2024 16:54
@eirikurj
Copy link
Contributor

@hajdik changes are fine, but I think we should add support for the new intel compiler. See idwarp for reference. Can you add this? We can also add this in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants