-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intel config #14
base: main
Are you sure you want to change the base?
Intel config #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following other best practices would be a much larger effort and would probably involve restructuring the repo a bit. I opened #15 to track some updates that should be made eventually.
This looks fine other than the Python formatting and my one comment below.
bump @hajdik |
1 similar comment
bump @hajdik |
@hajdik changes are fine, but I think we should add support for the new intel compiler. See idwarp for reference. Can you add this? We can also add this in a separate PR. |
Purpose
The intel config didn't work on Pleiades so I added the switch in the IDWarp intel config which did successfully build on the cluster and relevant pyGeo tests passed. I didn't refactor the rest of the config as it does work but if there are best practices to follow I can do so.
Also edited some Python files to address Black rules that are new since the last GeoGrad PR.
Expected time until merged
No rush
Type of change
Testing
Config runs on intel images
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable