Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in flag for calculating the heat flux per unit area or for total surface #704

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ChrisPsenica
Copy link
Contributor

Heat flux is normally calculated per unit area. The "scheme" flag will allow the user to change this. The two options are "byUnitArea" which is how DAFoam normally calculates the heat flux or "total" (the new method) which returns the entire heat transfer value over the surface of interest. If "scheme" is not specified then the default value will be "byUnitArea".

@ChrisPsenica ChrisPsenica requested a review from a team as a code owner November 14, 2024 16:32
@friedenhe friedenhe merged commit 17bcaf0 into mdolab:main Nov 14, 2024
12 checks passed
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (bd386fd) to head (1649d8f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/adjoint/DAObjFunc/DAObjFuncWallHeatFlux.C 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   86.22%   86.20%   -0.03%     
==========================================
  Files         333      333              
  Lines       22718    22727       +9     
==========================================
+ Hits        19588    19591       +3     
- Misses       3130     3136       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants