Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.md #37339

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update index.md #37339

wants to merge 3 commits into from

Conversation

geryogam
Copy link
Contributor

No description provided.

@geryogam geryogam requested a review from a team as a code owner December 22, 2024 15:01
@geryogam geryogam requested review from chrisdavidmills and removed request for a team December 22, 2024 15:01
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Dec 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

Preview URLs

Flaws (48)

URL: /en-US/docs/Web/CSS/Cascade
Title: Introducing the CSS Cascade
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted

(comment last updated: 2024-12-24 14:21:50)

chrisdavidmills
chrisdavidmills requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @geryogam, and thank you for this fantastic contribution to MDN. It improves consistency with the rest of MDN, and significantly improves readability.

I've made some suggestions, but nothing serious.

All the best.

files/en-us/web/css/cascade/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/cascade/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/cascade/index.md Outdated
Only relevant to author styles are inline styles, declared with the `style` attribute. Normal inline styles take precedence over any other normal author styles, no matter the specificity of the selector. If `line-height: 2;` were declared in a `:root body p` selector block in any of the five imported stylesheets, the line height would still be `1.6`.

Normal inline styles take precedence over any other normal author styles unless the property is being altered by a CSS animation.
Only relevant to author styles are inline styles, declared with the `style` attribute. Normal inline styles take precedence over any other normal author styles, no matter the specificity of the selector, unless the property is animated or transitioned. If `line-height: 2;` were declared in a `:root body p` selector block in any of the five imported stylesheets, the line height would still be `1.6`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure about this, but it feels like moving the bit about animations/transitions as you have done splits the previous point into two, making it slightly less obvious what the third sentence connects to or why it is there.

As a fix to this, maybe add to the end of the third sentence something like ", unless it is being animated."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I added a distinct sentence for animated and transitioned properties for normal inline styles, following the same structure as important inline styles.

files/en-us/web/css/cascade/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/cascade/index.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geryogam @chrisdavidmills