Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser-compat key for css <gradient> type #37331

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix browser-compat key for css <gradient> type #37331

merged 1 commit into from
Dec 23, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

bcd change occurs at mdn/browser-compat-data#25191, its functions has fixed in #37033, this fix the one

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Dec 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (48)

URL: /en-US/docs/Web/CSS/gradient
Title: <gradient>
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 21, 2024 15:10
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 21, 2024 15:10
@skyclouds2001 skyclouds2001 requested review from chrisdavidmills and removed request for a team December 21, 2024 15:10
@skyclouds2001 skyclouds2001 changed the title fix browser-compat key for css <gradient> type Fix browser-compat key for css <gradient> type Dec 21, 2024
chrisdavidmills
chrisdavidmills approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix, @skyclouds2001.

@chrisdavidmills chrisdavidmills merged commit 87516f2 into mdn:main Dec 23, 2024
7 checks passed
@skyclouds2001 skyclouds2001 deleted the gradient branch December 23, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @chrisdavidmills