Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some edits on the contributing doc for rari #37295

Merged
merged 3 commits into from
Dec 21, 2024
Merged

some edits on the contributing doc for rari #37295

merged 3 commits into from
Dec 21, 2024

Conversation

argl
Copy link
Contributor

@argl argl commented Dec 20, 2024

Description

Small change on flaw handling

Motivation

yari/rari transition

@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Dec 20, 2024
@argl argl marked this pull request as ready for review December 20, 2024 13:16
@argl argl requested a review from a team as a code owner December 20, 2024 13:16
@argl argl requested review from pepelsbey and removed request for a team December 20, 2024 13:16
bsmth
bsmth reviewed Dec 20, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
bsmth
bsmth approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@argl @bsmth
Update CONTRIBUTING.md
ebc8f3d 
Co-authored-by: Brian Smith <[email protected]>
pepelsbey
pepelsbey approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit 13443ea into main Dec 21, 2024
8 checks passed
@pepelsbey pepelsbey deleted the MP-1817-rari-doc-update branch December 21, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@argl @pepelsbey @bsmth