Fix info for svg <style> element
#37288
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs
(comment last updated: 2024-12-20 08:34:25) |
skyclouds2001
requested review from
hamishwillee
and removed request for
a team
| @@ -42,10 +42,10 @@ svg { | |||
|
|
|||
| - {{SVGAttr("type")}} | |||
| - : This attribute defines type of the style sheet language to use as a media type string. | |||
| _Value type_: [**\<string>**](/en-US/docs/Web/CSS/string); _Default value_: `text/css`; _Animatable_: **no** | |||
| _Value type_: [**`<content-type>`**](https://www.ietf.org/rfc/rfc2046.txt); _Default value_: `text/css`; _Animatable_: **no** | |||
There was a problem hiding this comment.
I'm not sure about this change as we prefer not to link to specs. Could we instead link to https://developer.mozilla.org/en-US/docs/Glossary/MIME_type and call it a<media-type> (the spec does)?
The rest looks good.
There was a problem hiding this comment.
P.S, mostly I think the linked doc is much more accessible than the spec.
There was a problem hiding this comment.
P.S. Just FYI @skyclouds2001 As I think I noted elswhere, I am here Monday, maybe Tuesday but then will be away a lot until Jan 20. So if something gets auto-assigned to me, you will either have to find someone else to look at it or wait. I don't want to hold you up!
skyclouds2001
commented
Dec 20, 2024
hamishwillee
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mediaattribute ( for<style>element) is not animatableupdate type for
<style>attributesMotivation
Additional details
https://svgwg.org/svg2-draft/styling.html#StyleElement
Related issues and pull requests