remove superflous and wrong selectors #36744
Merged
+3
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidStaus
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:Learn:Forms
|
Preview URLs Flaws (251)URL:
(comment last updated: 2024-12-23 00:12:34) |
files/en-us/learn/forms/how_to_structure_a_web_form/example/index.md
Outdated
Show resolved
Hide resolved
| @@ -125,7 +125,7 @@ form { | |||
| border-radius: 1em; | |||
| } | |||
|
|
|||
| div + div { | |||
| p + p { | |||
There was a problem hiding this comment.
I'm wondering if we should delete this selector altogether. There reference in https://developer.mozilla.org/en-US/docs/Learn/Forms/How_to_structure_a_web_form is that this is "extra styles you can try", but this makes very little difference visually unless you make it much better.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
merge conflicts 🚧
* textarea selector was used multiple times, even though there is no <textarea> in the HTML. div + div selector was changed to p + p, as all input and label elements are nested inside p elements, and not divs in the example.
hamishwillee
force-pushed
the
patch-2
branch
from
f2b6e74 to
a917a8d
Compare
files/en-us/learn_web_development/extensions/forms/how_to_structure_a_web_form/example/index.md
Show resolved
Hide resolved
hamishwillee
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Thanks for this @DavidStaus .
Note, you didn't respond to my review comments, so I have made those changes as I thought best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
div + div selector was changed to p + p, as all input and label elements are nested inside p elements, and not divs in the example.
Motivation
The extra selectors confused me as I was trying to copy the styling, and I thought there was something I had missed.
Additional details
Related issues and pull requests