Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): Accept-Encoding can appear in both requests and responses #36657

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Nov 5, 2024

Description

Accept-Encoding can appear in both requests and responses according to RFC 9110.

additions:

  • Brotli, Zstandard to cspell dicts

changes:

  • Requests and responses in prose
  • Update header type
  • Make isolated example generic

Related issues and pull requests

Fixes #36653

@bsmth bsmth requested review from a team as code owners November 5, 2024 08:58
@bsmth bsmth requested review from hamishwillee and pepelsbey and removed request for a team November 5, 2024 08:58
@github-actions github-actions bot added Content:HTTP HTTP docs system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Preview URLs

(comment last updated: 2024-11-14 13:21:46)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bsmth

@hamishwillee hamishwillee merged commit 36b7aec into mdn:main Nov 14, 2024
9 checks passed
@@ -7,7 +7,9 @@ browser-compat: http.headers.Accept-Encoding

{{HTTPSidebar}}

The HTTP **`Accept-Encoding`** {{Glossary("request header")}} indicates the content encoding (usually a compression algorithm) that the client can understand. The server uses [content negotiation](/en-US/docs/Web/HTTP/Content_negotiation) to select one of the proposals and informs the client of that choice with the {{HTTPHeader("Content-Encoding")}} response header.
The HTTP **`Accept-Encoding`** {{glossary("request header", "request")}} and {{glossary("response header")}} indicates the content encoding (usually a compression algorithm) that the recipient can understand.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamishwillee - I just noticed this should be "sender" not "recipient"... we should fix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yoiks. Good catch #36853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept-Encoding should be valid for both Request & Response, instead of only for Request
2 participants