Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globals, part 17: clearTimeout() & setTimeout() #36062

Merged
merged 28 commits into from
Oct 7, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 26, 2024

Description

Motivation

Additional details

Related issues and pull requests

part of the #33019

/cc @wbamberg

@github-actions github-actions bot added Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Glossary Glossary entries Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Sep 26, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Sep 26, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

Preview URLs (73 pages)
Flaws (102)

Note! 64 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/50
Title: Firefox 50 for developers
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/webkitGetEntries does not exist

URL: /en-US/docs/Mozilla/Firefox/Releases/3/Updating_extensions
Title: Updating extensions for Firefox 3
Flaw count: 20

  • broken_links:
    • Can't resolve /en-US/docs/Install_Manifests
    • Can't resolve /en-US/docs/Creating_a_Skin_for_Firefox/install.rdf
    • Can't resolve /en-US/docs/Install.js
    • Can't resolve /en-US/docs/Install_Manifests
    • Can't resolve /en-US/docs/Localizing_extension_descriptions
    • and 15 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers
Flaw count: 13

  • macros:
    • /en-US/docs/Web/API/MozSocial does not exist
    • /en-US/docs/Web/API/Navigator/mozSocial does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Simple_Push_API
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Alarm_API
    • Can't resolve /en-US/docs/Mozilla/Add-ons/WebExtensions/Embedded_WebExtensions
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Install_Manifests#multiprocesscompatible
    • and 6 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/5
Title: Firefox 5 for developers
Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/SVGPathSegList does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Character_Sets_Supported_by_Gecko
    • Can't resolve /en-US/docs/Web/HTTP_access_control
    • Can't resolve /en-US/docs/Mozilla/Firefox/Updating_add-ons
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Interface_Compatibility#binary_interfaces
    • Can't resolve /en-US/docs/JavaScript_code_modules/Dict.jsm
    • and 3 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/4
Title: Firefox 4 for developers
Flaw count: 46

  • macros:
    • /en-US/docs/Web/API/Element/isContentEditable does not exist
    • /en-US/docs/Web/API/Element/onbeforescriptexecute does not exist
    • /en-US/docs/Web/API/Element/onafterscriptexecute does not exist
    • /en-US/docs/Web/API/DragTransfer does not exist
    • /en-US/docs/Web/API/Event/mozInputSource does not exist
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Optimizing_graphics_performance
    • Can't resolve /en-US/docs/DOM/Animations_using_MozBeforePaint
    • Can't resolve /en-US/docs/DOM/HTMLWBRElement
    • Can't resolve /en-US/docs/Supporting_private_browsing_mode#detecting_whether_private_browsing_mode_is_permanent
    • Can't resolve /en-US/docs/Gecko-Specific_DOM_Events#mozafterpaint
    • and 33 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/56
Title: Firefox 56 for developers
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/formAction does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/formAction does not exist
    • /en-US/docs/Web/API/HTMLElement/wheel_event does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Headless_mode

URL: /en-US/docs/Mozilla/Firefox/Releases/13
Title: Firefox 13 for developers
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/FileError does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Gecko_user_agent_string_reference#mobile_and_tablet_indicators
    • Can't resolve /en-US/docs/Mozilla_MathML_Project/Fonts
    • Can't resolve /en-US/docs/Accessibility/AT-APIs/Gecko/Attrs

URL: /en-US/docs/Web/CSS/animation-timing-function
Title: animation-timing-function
Flaw count: 3

  • images:
    • External image URL
    • External image URL
    • External image URL

URL: /en-US/docs/Web/API/Window/clearInterval
Title: Window: clearInterval() method
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/SetTimeout redirects to /en-US/docs/Web/API/Window/setTimeout
    • /en-US/docs/Web/API/ClearTimeout redirects to /en-US/docs/Web/API/Window/clearTimeout
External URLs (8)

URL: /en-US/docs/Mozilla/Firefox/Releases/50
Title: Firefox 50 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/3/Updating_extensions
Title: Updating extensions for Firefox 3


URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/5/Updating_add-ons
Title: Updating add-ons for Firefox 5


URL: /en-US/docs/Mozilla/Firefox/Releases/56
Title: Firefox 56 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/55
Title: Firefox 55 for developers


URL: /en-US/docs/Web/JavaScript/Language_overview
Title: JavaScript language overview


URL: /en-US/docs/Web/API/WorkerGlobalScope/setTimeout
Title: WorkerGlobalScope: setTimeout() method

(comment last updated: 2024-10-05 16:37:00)

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Sep 29, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Sep 29, 2024
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@Josh-Cena Josh-Cena requested review from wbamberg and removed request for chrisdavidmills October 4, 2024 14:54
@skyclouds2001 skyclouds2001 requested a review from wbamberg October 5, 2024 11:12
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @skyclouds2001 !

@chrisdavidmills chrisdavidmills merged commit 1b4e6d1 into mdn:main Oct 7, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the timeout branch October 7, 2024 11:37
yin1999 added a commit to mdn/translated-content that referenced this pull request Oct 8, 2024
yin1999 added a commit to mdn/translated-content that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Games Games docs Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:JavaScript Learning area JavaScript docs Content:Learn Learning area docs Content:Performance Web performance docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants