Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Glossary for Cloud #36026

Merged
merged 14 commits into from
Oct 16, 2024
Merged

Conversation

ragul1697
Copy link
Contributor

Description

Fixes #35519 - Added Glossary item for Cloud

Additional details

Since MDN focuses on the web, it might be beneficial to include content about hosting web applications. Additionally, adding information about cloud services and cloud service providers could be valuable.

@ragul1697 ragul1697 requested a review from a team as a code owner September 24, 2024 09:26
@ragul1697 ragul1697 requested review from chrisdavidmills and removed request for a team September 24, 2024 09:26
@github-actions github-actions bot added Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels Sep 24, 2024
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Preview URLs

External URLs (5)

URL: /en-US/docs/Glossary/Cloud_computing
Title: Cloud computing


URL: /en-US/docs/Glossary/Cloud
Title: Cloud

(comment last updated: 2024-10-16 06:16:44)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @ragul1697, and thank you for your contribution to MDN! I've provided you with a few comments to consider, although I think this is largely going in the right direction.

files/en-us/glossary/cloud/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud/index.md Outdated Show resolved Hide resolved
@ragul1697
Copy link
Contributor Author

Thanks for all the comments. I will make the changes soon and let you know.

@cwangsanata
Copy link
Contributor

I think another good addition would be to include different cloud deployment style (e.g. Private Cloud, Public Cloud, etc.) as mentioned in the NIST Definition of Cloud Computing. Also including the document itself could be a good source for additional reading.

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Oct 4, 2024
@ragul1697
Copy link
Contributor Author

Hi @chrisdavidmills, I have made some changes for the Glossary item on Cloud Computing. Pease have a look at it. Thanks

@chrisdavidmills chrisdavidmills self-requested a review October 4, 2024 13:24
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ragul1697 great work., thank you so much. This content is interesting and useful. I've provided a bunch of comments, but most of them are fairly minor grammar/consistency updates.

The only really major one is the last one; I really don't think you need the last section.

files/en-us/glossary/cloud/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud_computing/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud_computing/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud_computing/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud_computing/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud_computing/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud_computing/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/cloud_computing/index.md Outdated Show resolved Hide resolved
@ragul1697
Copy link
Contributor Author

Hi @chrisdavidmills, completed all the changes requested. Thank you✌️

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Oct 15, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken liberty to reorganize the "cloud computing" page so it is much terser and doesn't use headings, but all information is still there. This looks great and we just need approval from @chrisdavidmills

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, approving!

Thanks to @Josh-Cena for helping to tidy this up. I also made a small edit to tighten the text up a bit further (the second paragraph was a bit wordy, and used "cloud services" too often). I am really happy with this now.

Our biggest thanks here must go to @ragul1697 for sticking with us through all the change requests and producing a nice piece of content for MDN. Your contribution is much appreciated!

@chrisdavidmills chrisdavidmills merged commit 99c2c3a into mdn:main Oct 16, 2024
8 checks passed
@ragul1697
Copy link
Contributor Author

Thank you @chrisdavidmills.

@ragul1697 ragul1697 deleted the 35519-glossary-cloud branch October 16, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add glossary: cloud
4 participants