Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-context(): Rewrite introduction for clarity #35941

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

paulirish
Copy link
Contributor

@paulirish paulirish commented Sep 18, 2024

Description

Rewrite the initial explanation of host-context().

Motivation

The current wording is difficult and hard to understand.

The [...] function selects the shadow host of the shadow DOM containing the CSS it is used inside

"the CSS" ? Also IMO weird to specify what it's "selecting" as the first sentence instead of why you may want to use it.

Hopefully you don't mind the rewrite. :)

Related issues and pull requests

none!

Hi estelle! :) <3z

@paulirish paulirish requested a review from a team as a code owner September 18, 2024 16:31
@paulirish paulirish requested review from estelle and removed request for a team September 18, 2024 16:31
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Preview URLs

(comment last updated: 2024-10-07 19:59:51)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @paulirish.

Thanks for the suggested edits. I made some additional suggestion for content that is missing from the page by elaborating on your greenhouse and chameleon example as well as a suggestion to add specificity info. Feel free to edit my suggestions.

files/en-us/web/css/_colon_host-context/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_host-context/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_host-context/index.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@estelle estelle merged commit c9b949b into mdn:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants