Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifying description and code for static block 'var' hoisting #35793

Merged
merged 3 commits into from
Sep 8, 2024
Merged

clarifying description and code for static block 'var' hoisting #35793

merged 3 commits into from
Sep 8, 2024

Conversation

getify
Copy link
Contributor

@getify getify commented Sep 8, 2024

I was confused by how the "hoisting" issue with var inside class static blocks was explained, and illustrated with the code. I clarified that var does in fact hoist, but only within the block. Tweaked the code to illustrate that fact.

@getify getify requested a review from a team as a code owner September 8, 2024 04:25
@getify getify requested review from Josh-Cena and removed request for a team September 8, 2024 04:25
@github-actions github-actions bot added Content:JS JavaScript docs size/s [PR only] 6-50 LoC changed labels Sep 8, 2024
…tion_blocks/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Preview URLs

(comment last updated: 2024-09-08 05:15:33)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks!

@Josh-Cena Josh-Cena merged commit 11b7591 into mdn:main Sep 8, 2024
8 checks passed
@getify getify deleted the patch-1 branch September 8, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants