Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS @custom-media at-rule #35755

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add CSS @custom-media at-rule #35755

wants to merge 13 commits into from

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Sep 5, 2024

Description

Media Queries Level 5 spec defines the @custom-media at-rule. This PR adds a new article to MDN explaining how and when to use Custom Media Queries.

Additional details

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Preview URLs

(comment last updated: 2024-10-04 08:03:34)

@ramiy ramiy marked this pull request as ready for review September 9, 2024 05:51
@ramiy ramiy requested a review from a team as a code owner September 9, 2024 05:51
@ramiy ramiy requested review from estelle and removed request for a team September 9, 2024 05:51
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I must have accidentally dismissed this from my notifications.

files/en-us/web/css/@custom-media/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Show resolved Hide resolved
files/en-us/web/css/@custom-media/index.md Outdated Show resolved Hide resolved
@ramiy ramiy requested a review from estelle October 4, 2024 08:05
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks.

@estelle estelle added the waiting for implementations Waiting for feature to be implemented in browsers label Oct 7, 2024
@ramiy
Copy link
Contributor Author

ramiy commented Oct 14, 2024

@estelle reminding you to merge this article.

@estelle
Copy link
Member

estelle commented Oct 18, 2024

Hi @ramiy. I asked about merging this and was told the MDN policy is to wait for at least one implementation, so I add the "waiting for implementation" tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed waiting for implementations Waiting for feature to be implemented in browsers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants