-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigator: cookieEnabled warning regarding Safari is outdated #32845 #35725
Conversation
Signed-off-by: Kowshik BV <[email protected]>
Tagging Hamish since I think it's related to cookie privacy. Especially the note below that talks about experimental Firefox—maybe these changes should be elaborated on? |
I'll look on Friday. Thanks @Josh-Cena @kaushik95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, but this is not the right fix - all this text should be removed and the information should be added to the compatibility data.
I am confirming the best way to do that and will update this afterwards.
Preview URLs (comment last updated: 2024-09-11 02:58:58) |
@kaushik95 I've added two suggestions to remove the note altogether - can you please accept them (your github branch isn't set up to take changes)? Then we can merge this once mdn/browser-compat-data#24402 goes in. Note, we don't need the info about IE anymore, so once this is in the compatibility data, the whole note isn't needed. |
Removed note section as it is not needed. Signed-off-by: kaushik95 <[email protected]>
@hamishwillee - Removed the note altogether. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much.
Description
Fixes issue #32845
Motivation
I'm interested in solving issues.
Additional details
Related issues and pull requests
"Fixes #32845"