fragmentDirective - live examples #35716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2024-09-12 23:16:39) |
hamishwillee
commented
Sep 3, 2024
8 tasks
bsmth
reviewed
Sep 11, 2024
bsmth
reviewed
Sep 11, 2024
bsmth
reviewed
Sep 11, 2024
bsmth
reviewed
Sep 11, 2024
bsmth
approved these changes
Sep 11, 2024
Co-authored-by: Brian Thomas Smith <[email protected]>
|
Thanks @bsmth . Good suggestions. Merged :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF131 adds support for text fragments in https://bugzilla.mozilla.org/show_bug.cgi?id=1914877
This just adds a live example logging whether the feature is supported by checking for existence of the
Document.fragmentDirective. Not strictly necessary, but since this is the main use of the interface, and we can check the object, it is kind of useful to do so.I would also have added in page-examples for text fragment highlighting and the use of the CSS, but that is more challenging with live examples :-0
Related docs tracked in #35703